-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: do not create tag when there are no public changes #414
base: main
Are you sure you want to change the base?
Conversation
Do we want to check all the commit messages between the last tag and head for the If that's the case I have the fix stashed and I can update this PR with that approach. |
Hey @suft, thanks for helping out with this!
Yes, I think that is the behavior we'd want. Ideally we'd match the Meta prefix case insensitive. |
3032809
to
67a1aad
Compare
Thanks @suft for your take on this. While this is definitely a quick fix for the problem, I do not find it optimal because it duplicates the logic we already have in |
@suft Thanks again for your update. The new version won't work, unfortunately, because the output of the tag creation goes to Furthermore, the name of the script Now that I think more about it, though, I think the two scripts might still be separate, but we should only reduce the two workflows into one. The My offer is still valid, I can implement this myself during the next days. If you @suft are motivated, though, feel free to continue on this. Your effort is very much appreciated! 🙏 |
Another thing just came to my mind: there was a reason we had the tag and release actions separate, and that is we want to have the possibility to trigger custom releases by creating a tag manually. So the new combined workflow should also support this (i.e. triggered on tag creation and create tag only if it does not exist, yet). |
Check list
Description
forgit-24.12.0.tar.gz
for 24.12.0 tag #413Type of change
Test environment